Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT error when merging a previously undefined array [DATAREST-959] #1329

Closed
spring-projects-issues opened this issue Dec 12, 2016 · 2 comments
Closed
Assignees
Labels
type: bug
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Dec 12, 2016

Milos Cubrilo opened DATAREST-959 and commented

An UnsupportedOperationException is thrown from DomainObjectReader.handleArrayNode(DomainObjectReader.java:272) in case when json update (new) object node contains an array property that was undefined in the source (old) object


Backported to: 2.6 RC1 (Ingalls), 2.5.6 (Hopper SR6)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Dec 13, 2016

Milos Cubrilo commented

A failing unit test and a fix added: #246

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Dec 13, 2016

Oliver Drotbohm commented

That should be in place now. I've added a couple more advanced fixes that sort of relate to the same problem. We're now skipping merging of null values completely and also back out on a potential non-collection source value.

Thanks for the PR. Feel free to give the snapshots a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

2 participants