Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention spring.data.rest.base-path for Spring Boot 2 in the reference documentation [DATAREST-1211] #1571

Open
spring-projects-issues opened this issue Mar 9, 2018 · 2 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Mar 9, 2018

Marc Tarin opened DATAREST-1211 and commented

Paragraph 3.6.2. Changing the base URI of the Spring Data Rest reference documentation mentions spring.data.rest.basePath for Spring Boot 1.2+.
It should now also mention spring.data.rest.base-path for Spring Boot 2.0.0.


Affects: 3.0.5 (Kay SR5)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 28, 2018

Florian Lüdiger commented

I don't really understand where your problem is. I tried using spring.data.rest.basePath and spring.data.rest.base-path with Spring Boot 2.0.2 and both seem to work fine. Spring Boot 2.0.0 falls into the category "Spring Boot 1.2+", so everything looks fine for me in the documentation

Loading

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 28, 2018

Marc Tarin commented

As far as I recall, I posted this while making configuration changes to a project that I had upgraded from SB 1.5.x to 2.0.0. spring.data.rest.basePath did not work for me (it did with SB1.5), but spring.data.rest.base-path did.

I know Spring Boot configuration uses a relaxed binder and that both syntaxes should work. I don't know whether it's a configuration issue or not, I didn't look further, it just didn't work in my case.

Since the Spring Boot documentation mainly uses the dash-cased convention (in the Common application properties appendix, both for Spring Boot 1.5.x and 2.0.x, in the Properties and configuration howto...), it just seem logical/useful to me to mention spring.data.rest.base-path

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants