Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-string values for lookup types [DATAREST-1321] #1629

Closed
spring-projects-issues opened this issue Dec 17, 2018 · 0 comments
Closed
Assignees
Labels
type: enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Dec 17, 2018

Pavel Horal opened DATAREST-1321 and commented

Current RepositoryInvokingDeserializer for some reason expects String to be used as entity identifier. Would be nice if it can support number values as well (by checking parser.getCurrentToken().isNumeric()).

LookupObjectSerializer is also assuming identifier to be always string, so this class should also support non-string identifiers (namely numeric identifiers)


Affects: 3.1.3 (Lovelace SR3)

Reference URL: https://github.com/spring-projects/spring-data-rest/blob/master/spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/json/PersistentEntityJackson2Module.java#L766

Backported to: 3.1.4 (Lovelace SR4), 3.0.13 (Kay SR13), 2.6.18 (Ingalls SR18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants