DATACMNS-918, DATAREST-910 - Support nested Sort properties. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
force-pushed
the
issue/DATACMNS-918
branch
from
cf82c6b
to
3e31c70
Compare
…nt resolvers. Prepare issue branch.
We now support nested Sort properties considering Jackson mapping. Sort translation is optional and skipped if the domain class is not resolvable. Translation in the scope of a domain class maps property paths to apply sorting using embedded properties.
A sort string `nested-name` resolves to a property path `anotherWrap.embedded.name`.
class Aggregate {
@JsonUnwrapped
public UnwrapEmbedded anotherWrap;
}
class UnwrapEmbedded {
@JsonUnwrapped(prefix = "nested-")
public Embedded embedded;
}
class Embedded {
public String name;
}
mp911de
force-pushed
the
issue/DATACMNS-918
branch
from
3e31c70
to
08d37c2
Compare
odrotbohm
pushed a commit
that referenced
this pull request
Dec 6, 2016
… resolvers. Original pull request: #232.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 6, 2016
We now support nested Sort properties considering Jackson mapping. Sort translation is optional and skipped if the domain class is not resolvable. Translation in the scope of a domain class maps property paths to apply sorting using embedded properties.
A sort string `nested-name` resolves to a property path `anotherWrap.embedded.name`.
class Aggregate {
@JsonUnwrapped
public UnwrapEmbedded anotherWrap;
}
class UnwrapEmbedded {
@JsonUnwrapped(prefix = "nested-")
public Embedded embedded;
}
class Embedded {
public String name;
}
Original pull request: #232.
odrotbohm
added a commit
that referenced
this pull request
Dec 6, 2016
Minor code reorganizations. Eagerly create SortTranslator to avoid repeated instantiation. Original pull request: #232.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 6, 2016
… resolvers. Original pull request: #232.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 6, 2016
We now support nested Sort properties considering Jackson mapping. Sort translation is optional and skipped if the domain class is not resolvable. Translation in the scope of a domain class maps property paths to apply sorting using embedded properties.
A sort string `nested-name` resolves to a property path `anotherWrap.embedded.name`.
class Aggregate {
@JsonUnwrapped
public UnwrapEmbedded anotherWrap;
}
class UnwrapEmbedded {
@JsonUnwrapped(prefix = "nested-")
public Embedded embedded;
}
class Embedded {
public String name;
}
Original pull request: #232.
odrotbohm
added a commit
that referenced
this pull request
Dec 6, 2016
Minor code reorganizations. Eagerly create SortTranslator to avoid repeated instantiation. Original pull request: #232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support nested
Sortproperties considering Jackson mapping.Sorttranslation is optional and skipped if the domain class is not resolvable. Translation in the scope of a domain class maps property paths to apply sorting using nested properties.We also use
SortArgumentResolverandPageableArgumentResolverto resolve and post-processSortandPageablearguments.A sort string
nested-nameresolves to a property pathanotherWrap.embedded.name.Related ticket: DATAREST-910
Depends on: spring-projects/spring-data-commons#179