Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registration of custom converters with multicore support enabled. [DATASOLR-173] #295

Closed
spring-projects-issues opened this issue Jun 17, 2014 · 4 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jun 17, 2014

Christoph Strobl opened DATASOLR-173 and commented

It should be possible to register converters for specific cores with multicore support enabled.

Something like:

@Bean
public CustomConversionsMap mappedConversions() {
  return CustomConversionsMap.forCollection("collection1").add(Converter...
}

that gets picked up if declared an is applied to the template when creating it


Reference URL: http://stackoverflow.com/questions/24254287/how-do-i-register-custom-converters-in-spring-data-solr-with-multicoresupport-en

2 votes, 4 watchers

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 23, 2014

Jonathan Inloes commented

It might also be nice to be able to register some global converters. I noticed that for each core a new SolrTemplate that's created the default converters are used.
SolrRepositoryFactory L83 SolrTemplate template = new SolrTemplate(factory);

Maybe a bean reference to a global 'solrConverter' can be included with the @EnableSolrRepositories(multicoreSupport=true)? For some use cases, this might be sufficient if the same conversions are needed across different cores in the case of denormalized data

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 23, 2016

David Kane commented

I'm trying to register some custom converters with multicore support enabled but I'm getting a ConverterNotFoundException.

Looking into the MappingSolrConverter inside the SolrTemplate I see that my Converter's are missing.

What's the workaround for this? Not to use "multicoreSupport = true" if needing to use a Converter?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 24, 2016

Christoph Strobl commented

@Geditdk I've just pushed some changes to issue/DATASOLR-173. build artifiacts are already availabe via repo.spring.io if you want to give the latest 2.1.0.DATASOLR-173-SNAPSHOT a try

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 24, 2016

David Kane commented

@Christoph Strobl I've given it a try and it works great, thanks a ton for looking into this so quickly. Awesome stuff. :D Will this be part of the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants