Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback method [DATASOLR-438] #559

Closed
spring-projects-issues opened this issue Dec 13, 2017 · 0 comments
Closed

Rollback method [DATASOLR-438] #559

spring-projects-issues opened this issue Dec 13, 2017 · 0 comments
Assignees

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Dec 13, 2017

Alen Dvorak opened DATASOLR-438 and commented

Hi, I am still new to Spring Solr, but I maybe found some inconsistency in SolrTemplate.

Commit methods send collection name but rollback method doesn't. I checked last versions and it changed a lot in last releases so I am not sure but my Solr 6.6 needs collection name for rollback.

@Override
	public void commit(String collection) {
		execute(solrClient -> solrClient.commit(collection));
	}

	@Override
	public void softCommit(String collection) {

		execute(solrClient -> solrClient.commit(collection, true, true, true));
	}

	@Override
	public void rollback(String collection) {
		execute(SolrClient::rollback);
	}

Affects: 3.0.2 (Kay SR2)

Referenced from: commits 8b27080, d439a7a

Backported to: 3.0.6 (Kay SR6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants