SPR9157 draft #19

merged 3 commits into from Mar 1, 2012


None yet
2 participants

The converter in this very little project without any security, interceptors etc. works fine.
However, the project the issue happens is much more complex.
It might be difficult to demostrate the issue as a sample.

rstoyanchev was assigned Feb 26, 2012

The demo for the issue is created.

I think the issue is on the line 432 in GenericConversionService.ConverterAdapter:
return this.typeInfo.getTargetType().equals(targetType.getObjectType());

In my view it should be:
return this.typeInfo.getTargetType().isAssignableFrom(targetType.getObjectType());

If you compare the version of 3.0.6 and 3.0.7 of GenericConversionService, you'll see that those lines were only added in 3.0.7.

@rstoyanchev rstoyanchev added a commit that referenced this pull request Mar 1, 2012

@rstoyanchev rstoyanchev Merge pull request #19 from ferengra/master
SPR9157 draft

@rstoyanchev rstoyanchev merged commit 990eadf into spring-projects:master Mar 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment