Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Grails BeanBuilder into Spring Core [SPR-7123] #11783

Closed
spring-projects-issues opened this issue Apr 22, 2010 · 9 comments
Closed

Migrate Grails BeanBuilder into Spring Core [SPR-7123] #11783

spring-projects-issues opened this issue Apr 22, 2010 · 9 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Apr 22, 2010

Jeff Brown opened SPR-7123 and commented

The Spring Bean Builder has been extracted from Grails and is being prepared for inclusion in Spring. Much of the development work on the builder itself is done. Work needs to be done to integrate the code into the core spring build.


1 votes, 10 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 28, 2012

Chris Beams commented

Jeff, is this still something the Grails team is interested in? The spring-framework build is now happily on Gradle, so should ease the process for you. Let's discuss if you're interested.

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 29, 2012

Jeff Brown commented

Definitely. I will work up a pull request per our discussion.

Thanks.

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 28, 2012

Chris Beams commented

See Jeff's comments at c463fd0#commitcomment-1775388

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 28, 2012

Chris Beams commented

Assigned to myself for review.

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 29, 2012

Jeff Brown commented

Chris,

Are you integrating the lang-groovy subproject into one of the others or are you waiting for me to do that?

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 29, 2012

Chris Beams commented

Thanks for asking - I'm planning to do it.

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 27, 2012

Craig Walls commented

With 3.2.0.RC1 dropping soon and this only existing in a branch, I'm guessing 3.2.0.RC1 won't be seeing Groovy config? Is this a sign that it won't be in 3.2.0 at all? I only ask because I've been asked about this a few times in the past couple of weeks and am not sure how to respond--and honestly, I'd be keen on doing Groovy-based config if it were part of Spring.

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 29, 2012

Chris Beams commented

Craig,

Indeed we had intended to get this in for RC1 but -- with apologies to the Grails team -- we haven't done so in time. At this point we simply won't have enough time for proper feedback on this in the 3.2 cycle, and so must move it forward to 3.3 (which I'm doing now). I'll be following up with Jeff Brown and Guillaume about this as we move into 3.3, where we're considering various options around promoting Groovy anyway.

Loading

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 17, 2013

Juergen Hoeller commented

Finally, we got a cut in Spring Framework master now - based on Jeff's latest pull request but heavily refactored and restructured.

The public entry points are org.springframework.beans.factory.groovy.GroovyBeanDefinitionReader and org.springframework.context.support.GenericGroovyApplicationContext now, closely modelled after Spring 3.0's GenericXmlApplicationContext and its relationship with XmlBeanDefinitionReader.

Juergen

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants