Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
When a bean definition is overridden, detect whether the definition has changed and log accordingly [SPR-7607] #12263
In a large configuration the 'Overriding bean definition' log message may be generated hundreds of times.
Referenced from: commits e7dde74
2 votes, 6 watchers
Juergen Hoeller commented
I suppose we could simply log at debug level for equal bean definitions... since that won't have any real effect anyway. And therefore restrict the info level logging to non-equal bean definitions (which it was intended for).
Isn't the real fix in the linked ticket? You say
Since it won't have any effect, why take the time to overwrite them? We're currently running a patched version of spring-beans with a very similar patch to what is in the linked ticket. One context load time went from 2 minutes 28 seconds to 25 seconds - other applications were even more drastic. Moving to java config is the long term solution, and we're working towards that, but with a large codebase it takes time.
For what it's worth, we haven't had to change any application code with the switch to the patched jar. I understand java config is the long term solution, but I don't understand why Pivotal would leave the linked ticket open and give the impression to legacy XML users that Spring doesn't scale well...
Side note - are the people commenting on #13410 really having a problem with the linked issue?