Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeanDefinitionRegistryPostProcessor registered via @Bean will not be invoked [SPR-7868] #12525

Closed
spring-projects-issues opened this issue Jan 9, 2011 · 4 comments
Labels
in: core status: declined

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 9, 2011

Henryk Konsek opened SPR-7868 and commented

I created simple bean implementing BeanDefinitionRegistryPostProcessor. All I want to do is to register some bean definition in the BeanDefinitionRegistryPostProcessor#postProcessBeanDefinitionRegistry method. The problem is that code working with ClassPathXmlApplicationContext doesn't work with AnnotationConfigApplicationContext.

My intelligent guess would be that BeanDefinitionRegistryPostProcessor#postProcessBeanDefinitionRegistry is called after JavaConfig bean postprocessor.

I'm attaching minimal Maven project with two unit tests (XmlTest & AnnotationTest) to demonstrate the issue.


Affects: 3.0.5

Attachments:

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 10, 2011

Chris Beams commented

Behavior Confirmed. Notice that RegisteringBean#postProcessBeanFactory is called, but #postProcessBeanDefinitionRegistry is not.

Good catch, thanks for filing the issue!

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 11, 2011

Chris Beams commented

Topic branch: https://github.com/cbeams/spring-framework/commits/SPR-7868. An early fix is there, but will need refinement.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented May 7, 2011

Chris Beams commented

This is a fundamental limitation of the @Configuration / @Bean approach. Because @Configuration classes are actually themselves processed by a BeanDefinitionRegistryPostProcessor, they cannot in turn register additional BeanDefinitionRegistryPostProcessors. -As a workaround you could register your BDRPP via XML and use @ImportResource, or perhaps more preferably, register it against the application context directly using AnnotationConfigApplicationContext#register(...)- See comment thread on #14099 for further explanation, workarounds and suggestions specific to MyBatis.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jul 5, 2013

Jarle Søberg commented

A possible work-around for this issue is to implement BeanDefinitionRegistryPostProcessor and PriorityOrdered as part of the definition of the Configuration:

@Configuration
public class A implements BeanDefinitionRegistryPostProcessor, PriorityOrdered {

    @Override
    public void postProcessBeanDefinitionRegistry(...) {
         ...
    }

    @Override
    public void postProcessBeanFactory(...) {
        ...
    }

    @Override
    public int getOrder() {
        return 0;
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: declined
Projects
None yet
Development

No branches or pull requests

1 participant