Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide OSGi regression test [SPR-8791] #13433

Closed
spring-issuemaster opened this issue Oct 20, 2011 · 2 comments
Closed

Provide OSGi regression test [SPR-8791] #13433

spring-issuemaster opened this issue Oct 20, 2011 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 20, 2011

Glyn Normington opened SPR-8791 and commented

There is currently no regression test of the OSGi manifests of the Spring framework bundles. So it is possible to introduce manifest changes which will prevent Spring framework being used as a drop-in upgrade for earlier versions of Spring. See #13431 for an example of this, which was caught relatively late in the day.

The suggested improvement is to introduce a nightly regression test of the ability to resolve Spring framework with a fixed basic set of non-optional dependencies. The test should probably fire up an OSGi framework such as Eclipse Equinox and install the Spring framework bundles and their non-optional dependencies. After this, the Spring framework bundles should be started and then the test should check that all of those bundles are in ACTIVE state.


Affects: 3.1 RC1

Issue Links:

  • #13431 New non-optional dependencies in org.springframework.web-3.1.0.RC1.jar
@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 8, 2011

Glyn Normington commented

A stand-alone testcase which builds under Gradle is available at https://github.com/glyn/testspringbundleresolution

See the README for build instructions, essentially:

gradle clean build

The tag Spring-3.1.0.RC2-successful indicates a level of the test which passes with Spring 3.1.0.RC2 (specified as a constant in the test class).

As a validation of the test, it produces the following failure when run against Spring 3.1.0.RC1 (see #13431 for matching diagnostics):

java.lang.AssertionError: The bundle "org.springframework.web_3.1.0.RC1 [20]" could not be resolved. Reason: Missing Constraint: Import-Package: org.apache.http; version="[4.1.0,5.0.0)"
at org.junit.Assert.fail(Assert.java:93)
at etc.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 12, 2019

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.