Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimeFormat javdoc mistake [SPR-8838] #13480

Closed
spring-issuemaster opened this issue Nov 11, 2011 · 1 comment
Labels
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 11, 2011

Patrick Radtke opened SPR-8838 and commented

The javadoc for DateTimeFormat says

"For custom formatting, set the pattern() attribute to be the DateTime pattern, such as yyyy/mm/dd h:mm:ss a."

This is example is misleading. MM is for month, while mm is for minutes - the example uses minutes where month is expected.
Someone who isn't paying attention will use the example pattern and wonder why their month is always January.

example should probably be "yyyy/MM/dd hh:mm:ss a" (capital M for moneths, extra h for hours)


Affects: 3.0.5

Referenced from: commits 4ededaf

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 12, 2011

Chris Beams commented

Thanks, Patrick. This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.