Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spring-test dependency on spring-aspects optional [SPR-9048] #13687

Closed
spring-projects-issues opened this issue Jan 23, 2012 · 3 comments
Closed
Labels
type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 23, 2012

Keith Donald opened SPR-9048 and commented

Was surprised when spring-test was brought down transitively just because I added spring-aspects to my list of dependencies.


Affects: 3.1 GA

Sub-tasks:

  • #13803 Backport "Make spring-test dependency on spring-aspects optional"

Referenced from: commits a9451d1

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 4, 2012

Chris Beams commented

commit a9451d11f6effeeddb22c12009c83fe0bcdb36f6 (HEAD, 3.1.x)
Author: Chris Beams <cbeams@vmware.com>
Date:   Sat Feb 4 17:39:21 2012 +0100

    Relax -aspects dependence on -test (compile=>test)
    
    The spring-aspects Maven pom had an incorrect compile-scoped dependence
    on spring-test. In fact, spring-aspects only uses spring-test in its
    unit tests. The pom has been updated accordingly, meaning that use
    of spring-aspects in Maven-based applications will no longer require
    spring-test on the classpath at runtime.
    
    ivy.xml metadata did not need updating, as it was already correct.
    
    This change is only necessary on the 3.1.x line; in 3.2.x (master) Maven
    poms are generated automatically from Gradle dependency metadata, which
    is also already correct.
    
    Issue: SPR-9048

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 24, 2012

Oliver Drotbohm commented

If there's a 3.0.8 coming, can we consider back-porting this? I just stumbled over this one for a project referencing Spring 3.0.7.RELEASE.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 24, 2012

Chris Beams commented

Ollie, see #13803. If and when we do a 3.0.8, we'll notice this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant