Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fix package cycle established by @EnableSpringConfigured" [SPR-9442] #14078

Closed
spring-projects-issues opened this issue May 25, 2012 · 1 comment
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented May 25, 2012

Chris Beams opened SPR-9442 and commented


This issue is a backport sub-task of #14077

Referenced from: commits 6263c9a

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 27, 2012

Chris Beams commented

commit 213710278b77c42103783b4351b37d583908866f
Author: Chris Beams <cbeams@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Fix package cycle in @EnableSpringConfigured
    
    @EnableSpringConfigured and its @Import'ed
    SpringConfiguredConfiguration @Configuration class inadvertently
    established a package cycle between beans.factory.aspectj and
    context.annotation due to SpringConfiguredConfiguration's
    dependency on annotations such as @Configuration, @Bean and @Role.
    
    This commit fixes this architecture bug by moving
    @EnableSpringConfigured and SpringConfiguredConfiguration from the
    beans.factory.aspectj package to the context.annotation package where
    they belong.
    
    This change is assumed to be very low impact as @EnableSpringConfigured
    was introduced in 3.1.0 and relocation is happening as quickly as
    possible in 3.1.2. @EnableSpringConfigured is assumed to be infrequently
    used at this point, and for those that are the migration path
    is straightforward. When upgrading from Spring 3.1.0 or 3.1.1, update
    import statements in any affected @Configuration classes to reflect the
    new packaging.
    
    Backporter's note: this change causes Bundlor warnings in
    org.springframework.aspect as its manifest now "imports and exports the
    package org.springframework.context.annotation". To 'solve' this
    problem, `fail.on.warnings=false` has been added to build.properties.
    This means that future Bundlor-based warnings may go unnoticed.
    
    Issue: SPR-9442
    Backport-Issue: SPR-9441
    Backport-Commit: 5327a7a37d25b67ee2ae7d1ead2a3db6847767c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant