Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "DatabasePopulatorUtils uses non-transactional connection" [SPR-9465] #14100

Closed
spring-projects-issues opened this issue Jun 4, 2012 · 1 comment
Labels
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 4, 2012

Chris Beams opened SPR-9465 and commented


This issue is a backport sub-task of #14092

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 27, 2012

Chris Beams commented

commit a9c80bfd7b62b59a225d06165f09ca760b0b3b0f
Author: Oliver Gierke <ogierke@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Use transactional connection during db population
    
    Previously, DatabasePopulatorUtils#execute looked up a Connection from
    the given DataSource directly which resulted in the executed statements
    not being executed against a transactional connection (if any) which in
    turn resulted in the statements executed by the populator potentially
    not being rolled back.
    
    Now DataSourceUtils#getConnection is used to transparently take part in
    any active transaction and #releaseConnection is used to ensure the
    connection is closed if appropriate.
    
    Issue: SPR-9465
    Backport-Issue: SPR-9457
    Backport-Commit: 49c9a2a9157861bad53ec47b67c8d821b0b4655a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant