BeanFactory.getType(String) may not return a Proxy class depending on the order of bean declarations [SPR-9638]

[spring-projects-issues]

Rossen Stoyanchev opened SPR-9638 and commented

When one bean tries to find the type of another, via BeanFactory.getType(String), from an initialization method (e.g. InitializingBean), and when the target bean type is expected to be a JDK dynamic proxy, the actual type returned varies depending on whether the target bean is declared before or after the bean interrogating its type.

This is the mechanism used in Spring MVC to discover and cache @RequestMapping methods to invoke. Hence it's necessary to the presence of JDK proxies.

---

Affects: 3.1.2

Issue Links:

• BeanFactory.getType() can return inaccurate (non-proxied) type when using AOP [SPR-9602] #14236 BeanFactory.getType() can return inaccurate (non-proxied) type when using AOP ("is duplicated by")

2 votes, 6 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

I've added a project reproducing the issue:
https://github.com/SpringSource/spring-framework-issues/tree/master/SPR-9638

[spring-projects-issues]

Karsten Sperling commented

I'm having the opposite problem, in that findAnnotationOnBean, which uses getType internally, sometimes does not find annotations. This seems to happen when the bean has already been instantiated, causing getType to return the JDK proxy class rather than the base bean class. In this case findAnnotationOnBean then doesn't find the annotation I'm looking for, even though I got the bean name via getBeanNamesForAnnotation in the first place.

In my case the behaviour is even indeterministic, depending on the (varying) order in which getBeanNamesForAnnotation returns these beans.

[spring-projects-issues]

Marino Debeljuh commented

In version 4.3.10 still having same problem. Event listeners somethime throws exception because of this bug. In EventListenerMethodProcessor getType method is used to find target class but instead of proxy class sometime the real implementation class is returned. Because of that in ApplicationListenerMethodAdapter in method assertTargetBean exception is raised because of wrong method resolution (method from real class is executed on proxy instance)

[spring-projects-issues]

Marino Debeljuh commented

Found quick fix for my problem. getType returns wrong type only for lazy loaded bean (implementation class instead of proxy class). With @Lazy(false) on class getType correctly returns proxy class

[spring-projects-issues]

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.