Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding bean definition message does not take parent definition into account [SPR-9671] #14305

Closed
spring-projects-issues opened this issue Aug 7, 2012 · 1 comment
Assignees
Labels
in: core status: backported type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 7, 2012

Radim Kolar opened SPR-9671 and commented

It seems like this message contains just bean definition values, not real values merged with parent bean definition. It would be more useful if parent bean definition will be merged because for example lazyInit will be different.

2012-08-07 13:51:39,096 INFO [main] org.springframework.beans.factory.support.DefaultListableBeanFactory: Overriding bean definition for bean 'pluginmanager': replacing [Generic bean: class [null]; scope=; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null; defined in class path resource [nutch/conf/common/pluginmanager.xml]] with [Generic bean: class [null]; scope=; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=null; factoryMethodName=null; initMethodName=null; destroyMethodName=null; defined in class path resource [nutch/conf/fetch/pluginmanager.xml]]


Affects: 3.1.2

Attachments:

Referenced from: commits b13c5b2, 0ef29b2, bed739c

Backported to: 3.2.9

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 28, 2014

Juergen Hoeller commented

At that point of processing, bean definitions aren't being merged yet, and I would be odd to do so just for logging purposes. However, you do have a point that the parent bean isn't even mentioned in that log output: As a consequence, I've revised GenericBeanDefinition's toString() implementation correspondingly, being similar to ChildBeanDefinition's output now.

Juergen

@spring-projects-issues spring-projects-issues added status: backported type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: backported type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants