Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid per-request Pattern.compile() calls. [SPR-9749] #14383

Closed
spring-issuemaster opened this issue Sep 3, 2012 · 4 comments
Closed

Avoid per-request Pattern.compile() calls. [SPR-9749] #14383

spring-issuemaster opened this issue Sep 3, 2012 · 4 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Sep 3, 2012

Patrick Linskey opened SPR-9749 and commented


Affects: 3.1.1, 3.1.2, 3.2 M2

Issue Links:

  • #15429 MemoryLeak in AntPathMatcher during caching AntPathStringMatcher instances
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 3, 2012

Patrick Linskey commented

GitHub commit for 3.1.1: pcl@ca2bc82
GitHub commit for master: pcl@f038321

'./gradlew build' succeeds with this patch on master. I'm still trying to figure out how to get 3.1.1 to build on my machine (http://forum.springsource.org/showthread.php?129846-Spring-3-1-1-compilation&p=423733#post423733)

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 3, 2012

Patrick Linskey commented

FYI, this eliminates 3% of the CPU burn in my Spring-MVC app.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 3, 2012

Patrick Linskey commented

If the per-instance maps are a concern, it looks like the string matchers could also be cached statically / at a higher level, and shared among multiple parent matchers.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 10, 2012

Rossen Stoyanchev commented

This change has been applied to master and 3.1.x. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.