Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpDivide wrongly wraps result of division in TypedValue [SPR-9869] #14502

Closed
spring-projects-issues opened this issue Oct 10, 2012 · 1 comment
Closed
Assignees
Labels
in: core type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 10, 2012

Tomasz Wysocki opened SPR-9869 and commented

Fragment of code from OpDivide.java

	Object result = state.operate(Operation.DIVIDE, operandOne, operandTwo);
return new TypedValue(result);

wrongly wraps result of division in TypedValue.
Corresponding in OpMultiply.java is correct.

return state.operate(Operation.MULTIPLY, operandOne, operandTwo);

Fix is trivial.


Affects: 3.1.2

Referenced from: commits ad81ec9, 138fa8a

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 11, 2012

Juergen Hoeller commented

Good catch!

Juergen

@spring-projects-issues spring-projects-issues added type: bug in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.1.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: bug
Projects
None yet
Development

No branches or pull requests

2 participants