Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DispatcherPortlet should forward to view for ResourceRequest [SPR-9876] #14509

Closed
spring-issuemaster opened this issue Oct 11, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Oct 11, 2012

Eric Dalquist opened SPR-9876 and commented

The portlet specification allows for most of the interesting HttpServletResponse.set* methods to be mapped back to the corresponding ResourceResponse methods but ONLY if the portlet uses PortletRequestDisptacher.forward. If include is used the HttpServletResponse.set* methods are ignored.

This is especially important when using special views such as Jackson or CSV where a specific content-type or other headers need to be set.


Affects: 3.1.2

Issue Links:

  • #15417 In spring MVC portlet, @resourceMapping doesn't work.
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 11, 2012

Eric Dalquist commented

Pull Request: #165

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 12, 2012

Juergen Hoeller commented

That include call dates back to Portlet 1.0 where all we had was the include operation for render requests.

For resource requests, it seems that include doesn't actually make much sense? That would only be useful if the original resource request already got included somewhere else, which is rather unlikely. Is it even technically possible in the Portlet resource request model? Can you manually include another portlet's processing of a specific resource id?

I'm basically considering to always use a forward for resource requests and not even bother with a flag.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 12, 2012

Eric Dalquist commented

I've never seen a case where the include in a resource is used. I added the flag in the patch for compatibility but my original local fix in uPortal always used forward for resource handling.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 12, 2012

Juergen Hoeller commented

Alright, I went with the straight forward for resource requests, extracting a doDispatch method that can be overridden if somebody really insists. I don't think anyone will, and we've got so many configuration options already...

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.