Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameter names during MBeanInfo assembly [SPR-9985] #14619

Closed
spring-projects-issues opened this issue Nov 13, 2012 · 3 comments
Closed

Use parameter names during MBeanInfo assembly [SPR-9985] #14619

spring-projects-issues opened this issue Nov 13, 2012 · 3 comments
Assignees
Labels
in: core type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 13, 2012

David Boden opened SPR-9985 and commented

The behaviour of AbstractReflectiveMBeanInfoAssembler.getOperationParameters(method, beanKey) could be updated to use a org.springframework.core.LocalVariableTableParameterNameDiscoverer instead of returning the parameter names as p0, p1 etc.

I would imagine that the majority of internal corporate and open source applications typically compiled with class debug information available. Making use of this information would mean that JConsole would display meaningful method attribute names without the bother of using a @ManagedAttribute annotation.


Affects: 3.1.3

Issue Links:

  • INT-3110 Message Bus Broken with SF 3.2.3
  • #14849 Use parameter names during MBeanInfo assembly for MBean interfaces as well as @ManagedOperation

Referenced from: commits 4dde7c4

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 21, 2013

David Boden commented

Pull request on its own branch: #217

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 23, 2013

Juergen Hoeller commented

This is a good idea. Thanks for the submission, David!

For 3.2.1, I've added this to AbtractReflectiveMBeanInfoAssembler in a slightly reworked version, allowing to turn off parameter detection etc.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 25, 2013

David Boden commented

Thanks! Please see #14849 where I'm suggesting additional improvements for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants