Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShallowEtagHeaderFilter should deal with the If-Match HTTP Header [SPR-10164] #14797

Closed
spring-projects-issues opened this issue Jan 11, 2013 · 3 comments
Closed

ShallowEtagHeaderFilter should deal with the If-Match HTTP Header [SPR-10164] #14797

spring-projects-issues opened this issue Jan 11, 2013 · 3 comments
Assignees
@philwebb
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Milestone
4.0 RC1

Comments

@spring-projects-issues
Copy link
Collaborator

Eugen Paraschiv opened SPR-10164 and commented

ShallowEtagHeaderFilter supports the ```
If-None-Match

```If-Match
``` header as well. This would make the out of the box behaviour of this filter much more in sync with the HTTP spec (which is the whole point of the filter). 
The same shallow implementation would be fine here as well, same as now.

Affects: 3.2 GA

2 votes, 8 watchers
@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

If you have time to put together a pull request with the suggested change, I'll take a look.

@spring-projects-issues
Copy link
Collaborator Author

Eugen Paraschiv commented

Created pull request: #215
Thanks.
Eugen.

@spring-projects-issues
Copy link
Collaborator Author

Phil Webb commented

I am going to close this one for now until we have a little more understanding about the use-case this covers.

@spring-projects-issues spring-projects-issues added status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
4.0 RC1
Development

No branches or pull requests
2 participants
@philwebb @spring-projects-issues