Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShallowEtagHeaderFilter should deal with the If-Match HTTP Header [SPR-10164] #14797

Closed
spring-projects-issues opened this issue Jan 11, 2013 · 3 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 11, 2013

Eugen Paraschiv opened SPR-10164 and commented

ShallowEtagHeaderFilter supports the ```
If-None-Match

```If-Match
``` header as well. This would make the out of the box behaviour of this filter much more in sync with the HTTP spec (which is the whole point of the filter). 
The same shallow implementation would be fine here as well, same as now. 

Affects: 3.2 GA

2 votes, 8 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 11, 2013

Rossen Stoyanchev commented

If you have time to put together a pull request with the suggested change, I'll take a look.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 13, 2013

Eugen Paraschiv commented

Created pull request: #215
Thanks.
Eugen.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 21, 2013

Phil Webb commented

I am going to close this one for now until we have a little more understanding about the use-case this covers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants