Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary blocking in DelegatingFilterProxy [SPR-10413] #15046

Closed
spring-issuemaster opened this issue Mar 25, 2013 · 1 comment
Closed

Unnecessary blocking in DelegatingFilterProxy [SPR-10413] #15046

spring-issuemaster opened this issue Mar 25, 2013 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Mar 25, 2013

Yury Lapko opened SPR-10413 and commented

Unnecessary thread blocking occurs every time when the method doFilter is called. Can be used double check locking to avoid unnecessary thread blocking.


Affects: 3.2.2

Reference URL: https://github.com/SpringSource/spring-framework/blob/3.2.x/spring-web/src/main/java/org/springframework/web/filter/DelegatingFilterProxy.java

Issue Links:

  • #13904 Spring DelegatingFilterProxy synchronization in multi-threading ("is duplicated by")

Referenced from: commits c26272c, 20ddd32

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 2, 2013

Juergen Hoeller commented

Indeed, since we never reset the delegate reference once set, an extra check can be done ahead of the synchronized block, with the delegate variable marked as volatile.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.