BatchSqlUpdate support for named parameters [SPR-10435]

[spring-projects-issues]

Giovanni Botta opened SPR-10435 and commented

The BatchSqlUpdate class doesn't override the updateByNamedParam(Map<String,?> paramMap) method. It would be useful to override this so that named parameters would be supported when performing batch updates and the same map could be reused to pass the parameters around (simple and with minimal space overhead).

NamedParameterJdbcTemplate has the batchUpdate(String sql, Map<String,?>[] batchValues) method to do this but, besides having a different interface, it requires an array of maps, with increased overhead, code bloating and complication reusing the maps (http://stackoverflow.com/questions/15277584/spring-batchsqlupdate-vs-namedparameterjdbctemplate-using-named-parameters).

Thanks
Giovanni

---

Affects: 3.2 GA

Attachments:

• SPR-10435 small refactor.patch (4.35 kB)

[spring-projects-issues]

Giovanni Botta commented

I wrote a few lines of code to work around the lack of an update(Map) method:

// a SQL statement using named parameters, e.g., insert into t(c1,c2) values (:c1,:c2)
String sql = ...;
// list of named parameters, e.g., {new SqlParameter("c1",Types....),new SqlParameter("c2",Types....)}
List<SqlParameter> parameters = ...;
// the data source
DataSource dataSource = ...;

ParsedSql parsedSql = NamedParameterUtils.parseSqlStatement(sql)
String sqlToUse = NamedParameterUtils.substituteNamedParameters(parsedSql, null);

BatchSqlUpdate batchSqlUpdate = new BatchSqlUpdate(dataSource, sqlToUse);

for (SqlParameter p : parameters)
  batchSqlUpdate.declareParameter(p);

// the following method can be now used:
void update(Map<String, Object> record) {
  MapSqlParameterSource sqlParameterSource = new MapSqlParameterSource(record);
  Object[] params = NamedParameterUtils.buildValueArray(parsedSql, sqlParameterSource, parameters);
  batchSqlUpdate.update(params);
}

Note that my code uses the existing BatchSqlUpdate implementation. However, a new class extending BatchSqlUpdate could be created that overrides update(Map<String, Object> record) in the same fashion. Using inheritance or composition is just a design choice.
Bottom line: this is a very simple change, easy to implement and to test.

[spring-projects-issues]

Phil Webb commented

#285

[spring-projects-issues]

Giovanni Dall'Oglio Risso commented

Hello, forgive my intromission.

I propose a small refactor (find attached).
Thanks.

[spring-projects-issues]

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.