Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HttpHeaders#getIfNotModifiedSince() to getIfModifiedSince() to avoid confusing [SPR-10600] #15229

Closed
spring-issuemaster opened this issue May 29, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented May 29, 2013

Artem Bilan opened SPR-10600 and commented

See the linked issue and its PR.
In addition it would be useful to make some methods public:
getFirstDate
setDate


Affects: 3.1.4, 3.2.3, 4.0 M1

Issue Links:

  • INT-2995 If-Modified-Since is formatted date string but DefaultHttpHeaderMapper is handling it as long value and causes NumberFormatException

Referenced from: commits 38c2f25, 55f02db

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 26, 2013

Phil Webb commented

Unfortunately we cannot rename the method without breaking backwards compatibility. I have however deprecated the method and added a new one.

Please raise an improvement task is you would still like getFirstDate and setDate to be public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.