Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpHeaders should be tolerant with bad date-aware headers as it said in the RFC 2616 [SPR-10648] #15276

Closed
spring-issuemaster opened this issue Jun 12, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jun 12, 2013

Artem Bilan opened SPR-10648 and commented

See the Expires header description in the RFC.
Now if the value of similar header is not valid HttpHeaders throws IllegalArgumentException.
IMO it should return -1 as in case header is null.
In additions see the linked issue.

We'll be glad to hear any thoughts, why HttpHeaders works now such way?


Affects: 3.2.3

Reference URL: http://tools.ietf.org/html/rfc2616#page-127

Issue Links:

  • INT-3063 HTTP gateway response fails with non-standard expires header

Referenced from: commits 9245fff, 0f71da5

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 21, 2013

Rossen Stoyanchev commented

Arjen Poutsma, any objections? The RFC does say "HTTP/1.1 clients and caches MUST treat other invalid date formats, especially including the value "0", as in the past (i.e., "already expired")."

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 24, 2013

Arjen Poutsma commented

No objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.