Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring 3.2.2 AOP has increased memory usage [SPR-10709] #15337

Closed
spring-issuemaster opened this issue Jul 1, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jul 1, 2013

Kestutis Gedminas opened SPR-10709 and commented

Our project moved to spring 3.2.2 and observed increased memory usage. I tracked it down to UndeclaredThrowableStrategy. Older Spring versions used cglib implementation of it and it has memory usage fixed in
2.2.3 release.

But current spring version uses own implementation of the class which has memory issue - keeps ClassTransformer in private member when it is not actually used.
Attaching screenshots from Eclipse MAT.
In our project this uses 300-400 MB memory which gets wasted.


Affects: 3.2.2

Attachments:

Issue Links:

  • #16025 aop:scoped-proxy may fail with LinkageError: loader attempted duplicate class definition for name

Referenced from: commits af7753e, 587877c

1 votes, 4 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 2, 2013

Phil Webb commented

Thanks for the details report. We are actually using a repacked version of cglib 3.0 and it appears that, although the fix you pointed to is in HEAD, it has not yet been released in v3.X. Do you have a simple project that reproduces the issue so we can test any fix that we attempt?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 2, 2013

Kestutis Gedminas commented

I'm sorry, I don't have simple project for it.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2013

Phil Webb commented

I have pushed a potential fix for this. Would you be able to test the latest 3.2.4.BUILD-SNAPSHOT to see if it fixes your issue?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2013

Kestutis Gedminas commented

Tested 3.2.4.BUILD-20130719.215423 and it is fixed.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2013

Phil Webb commented

Excellent, thanks for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.