Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HttpHeaders getFirstDate(String headerName) and setDate(String headerName, long date) methods as public [SPR-10713] #15341

Closed
spring-issuemaster opened this issue Jul 2, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jul 2, 2013

Artem Bilan opened SPR-10713 and commented


Referenced from: commits b0675c0, cb77440

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 2, 2013

Phil Webb commented

See #15229 for some background

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2013

Rossen Stoyanchev commented

These methods are private because they are not part of MultivalueMap and the expectation is they shouldn't be needed. With that in mind can you shed some light on the use cases you have in mind?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2013

Artem Bilan commented

Hi, Rossen!
First of all,thank you for all your excellent work ;-)!

they are not part of MultivalueMap

Right. But setters and getters for specific headers aren't part of MultivalueMap too.
What I have in mind?
There is a standard header If-Unmodified-Since, who is a Date too, but there is no explicit methods to set and get it. See our issue in the Spring Integration: spring-projects/spring-integration#813
From other side I may be intrested in some custom headers in Date style. In this case I want follow with standard date formats as it is supported by HttpHeaders. So, or I copy/paste the methods from HttpHeaders, or it would be more consist to reuse the power of HttpHeaders.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 5, 2013

Rossen Stoyanchev commented

Ok thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.