jdbctemplate for keyholder [SPR-10867]

[spring-projects-issues]

skzr.org opened SPR-10867 and commented

I hope JdbcTemplate can support more with KeyHolder.

• updateRetKeyHolder like this:

public KeyHolder updateRetKeyHolder(final String sql, final Object... args) {
	logger.debug("Insert and return KeyHolder for SQL: {}", sql);
	KeyHolder keyHolder = new GeneratedKeyHolder();
	try {
		update(new PreparedStatementCreator() {
			@Override
			public PreparedStatement createPreparedStatement(Connection con) throws SQLException {
				PreparedStatement ps = con.prepareStatement(sql, Statement.RETURN_GENERATED_KEYS);
				setValues(ps, args);
				return ps;
			}
		}, keyHolder);
	} finally {
		StatementCreatorUtils.cleanupParameters(args);
	}
	return keyHolder;
}

• batchUpdateRetKeyHolder like this:

public <T> List<KeyHolder> batchUpdateRetKeyHolder(JdbcTemplate jdbcTemplate, final String sql, final List<T> beans) {
	logger.debug("Batch update with KeyHolder for SQL: {}, batch size: {}", sql, beans.size());
	final List<KeyHolder> keyHolders = new ArrayList<>(beans.size());
	
	execute(new PreparedStatementCreator() {
		@Override
		public PreparedStatement createPreparedStatement(Connection con) throws SQLException {
			return con.prepareStatement(sql, Statement.RETURN_GENERATED_KEYS);
		}
	}, new PreparedStatementCallback<int[]>() {
		@Override
		public int[] doInPreparedStatement(PreparedStatement ps) throws SQLException, DataAccessException {
			try {
				int batchSize = beans.size();
				int[] result;
				KeyHolder keyHolder = new GeneratedKeyHolder();
				
				try {
					if (JdbcUtils.supportsBatchUpdates(ps.getConnection())) {
						for (int i = 0; i < batchSize; i++) {
							setValues(ps, i);
							ps.addBatch();
						}
						result = ps.executeBatch();
						
						generatedKeys(ps, keyHolder);
					} else {
						List<Integer> rowsAffected = new ArrayList<Integer>();
						for (int i = 0; i < batchSize; i++) {
							setValues(ps, i);
							
							rowsAffected.add(ps.executeUpdate());
							generatedKeys(ps, keyHolder);
						}
						
						result = UtilCollection.tointArray(rowsAffected);
					}
				} finally {
					keyHolders.add(keyHolder);
				}
				
				return result;
			} finally {
				cleanupParameters();
			}
		}
	});
	return keyHolders;
}

---

Affects: 3.2.4

[spring-projects-issues]

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.