Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port @ConditionalOn... from Spring Boot into Spring Core [SPR-10964] #15592

Open
spring-issuemaster opened this issue Oct 7, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@spring-issuemaster
Copy link
Collaborator

commented Oct 7, 2013

Eberhard Wolff opened SPR-10964 and commented

Spring Boot provides many useful Conditional such as @ConditionalOnMissingBean, @ConditionalOnClass etc This should really be in the core framework. It would allow to detect the runtime environment (Java EE server? Which Java EE server?) and tweak the configuration accordingly.


Affects: 4.0 M3

Issue Links:

  • #20614 Adopt a spring boot Condition ("is duplicated by")
  • #15920 Include @ConditionalOnMissingBean and @ConditionalOnClass from Spring Boot

7 votes, 11 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 11, 2013

Phil Webb commented

We decided to intentionally leave the majority of the @Conditional implementations in Spring Boot for now whilst we develop them. The @ConditionalOnMissingBean can be particularly problematic as it depends on the order that bean definitions get evaluated. For Spring Boot this is not a problem because we only use it for auto-configuration beans (which are always evaluated last), for user applications it might introduce some very hard to track down bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.