Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad input type when calling processFieldValue for hiddens generated for checkboxes [SPR-11059]

Closed
spring-projects-issues opened this issue Nov 2, 2013 · 1 comment
Labels
in: web status: bulk-closed

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 2, 2013

Daniel Fernández opened SPR-11059 and commented

When calling "processFieldValue" for the values of the hidden inputs created as a companion for checkboxes in CheckboxTag and CheckboxesTag, the input type being passed to the RequestDataValueProcessor is "checkbox", but it seems it should be "hidden".

See:
https://github.com/spring-projects/spring-framework/blob/master/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/CheckboxTag.java#L61
and
https://github.com/spring-projects/spring-framework/blob/master/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/CheckboxesTag.java#L47

This is inconsistent with the hidden created at FormTag in order to keep a browser-incompatible method value:

https://github.com/spring-projects/spring-framework/blob/master/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java#L366


Affects: 3.2.4

@spring-projects-issues spring-projects-issues added type: bug status: waiting-for-triage in: web and removed type: bug labels Jan 11, 2019
@rstoyanchev rstoyanchev added status: bulk-closed and removed status: waiting-for-triage labels Jan 11, 2019
@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 12, 2019

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web status: bulk-closed
Projects
None yet
Development

No branches or pull requests

2 participants