Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
performancedrop due to repeated JDBC 3.0 getParameterType calls in setNull in StatementCreatorUtils [SPR-11100] #15726
We notice a performance drop after we updated to a (much newer) library (3.2.5). We used to work on 3.0.5.
We connect to Oracle11g with ojdbc 18.104.22.168 drivers.
After some testing we noticed that the performance drop was introduced by a changed implementation in setNull. Our queries have lots of columns ~40 with many optional values. For every NULL value, the driver is now asked ps.getParameterMetaData().getParameterType(paramIndex). The drivers don't support this yet but will throw an exception.
We notice that calling this method 30ish times costs us extra time (around 100ms), which is quite noticable. Requests which require 2 inserts went from ~200ms to 400+ms. We omitted the getparametertype call by editing the source of 3.2.5 to check our hypothesis and the performance was restored to its old state.
Is it possible to cache the 'unsupported state' in case the databasedrivers do not support it, so it's only executed once per request.
Below is the oracle implementation of getParameterType
SQLException localSQLException = DatabaseError.createUnsupportedFeatureSqlException();
PS: entered this issue as a bug because it impairs the function of the product
Somewhat related issue, different bug introduced due to the added functionality (#14818)
Backported to: 3.2.6
2 votes, 7 watchers
Juergen Hoeller commented
We're statically caching information about drivers which do not support that feature now. In case of multiple DataSources with different drivers, we're going to cache that information individually - but once cached, no further getParameterMetaData/getParameterType attempts are going to happen for the lifetime of that application (and the use of the same JDBC driver).