Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify bean qualifier in an AOP @Around / @Before / ... [SPR-11217] #15842

Closed
spring-issuemaster opened this issue Dec 12, 2013 · 2 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 12, 2013

Francisco Lozano opened SPR-11217 and commented

Right now it's possible to specify bean(beanName), but it'd be great if you could say qualifier(whatever) so that you can wire aspects not only by bean name or by usual AspectJ pointcuts, but also by bean qualifier, so that any bean configured with

@Bean
@Qualifier("audited")
public MyBean myBean() {}

The same cannot be achieved simply with annotations, as annotation is at class-level and not at bean-level (and I can re-use same class in several beans).


Affects: 3.2.5

Issue Links:

  • #13532 Convenient programmatic bean retrieval with qualifiers

Referenced from: commits 214c919

1 votes, 3 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 12, 2016

Juergen Hoeller commented

I've implemented this as bean(qualifier), i.e. within the same pointcut designator, simply not just matching against bean names and aliases but also against String qualifier values now. While this extends the semantics of our bean designator, I do not expect issues with existing setups since specific bean conditions are unlikely to accidentally match qualifier values in corresponding bean definitions.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 16, 2016

Francisco Lozano commented

This is great. I will try it tomorrow the first thing in the morning. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.