Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all tests are executed in the Gradle build for the spring-test module [SPR-11338] #15962

Closed
spring-projects-issues opened this issue Jan 21, 2014 · 1 comment
Assignees
Labels
in: test status: backported type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 21, 2014

Sam Brannen opened SPR-11338 and commented

TestNG tests are currently only executed by the Gradle build if they are located directly in the testng package. Tests in subpackages are therefore omitted from the build. As of the creation of this JIRA issue there are no such tests in subpackages; however, this is soon to change.

Furthermore, the JUnit-based FailingBeforeAndAfterMethodsTests test class is currently not executed because it resides under the testng package which is excluded from the test build target.


Affects: 3.2 GA

Referenced from: commits 098d7c7, fdac4a7

Backported to: 3.2.7

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 21, 2014

Sam Brannen commented

Resolved as described in the comments for GitHub commit 098d7c7 (4.0.1) and GitHub commit fdac4a7 (3.2.7):

Ensure all tests in spring-test are executed

Prior to this commit TestNG tests would only be executed by the Gradle
build if they were located in the “testng” package. Tests in subpackages
would therefore be omitted from the build.

This commit ensures that all TestNG classes in the “testng” package and
any of its subpackages are executed in the Gradle build.

Furthermore, this commit ensures that the JUnit-based
FailingBeforeAndAfterMethodsTests test class is executed along with the
other JUnit tests even though it resides under the “testng” package.

@spring-projects-issues spring-projects-issues added in: test status: backported type: task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test status: backported type: task
Projects
None yet
Development

No branches or pull requests

2 participants