Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative RestTemplate constructor to avoid default MessageConverter creation [SPR-11351] #15976

Closed
spring-projects-issues opened this issue Jan 23, 2014 · 6 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 23, 2014

Kek opened SPR-11351 and commented

The default MessageConverters are initialized in constructor of RestTemplate. This solution has some problems:

  1. When I want different set of MessageConverters, the default MessageConverters are initialized first and than replaced by setMessageConverters(..) method. This slows down the application startup.

  2. When I have some classes as JAXB, Jackson on classpath, than some other default converters are initialized too (but I don't use these technologies (JAXB, Jackson) with RestTempate) - this slows down the startup, so I want to specify my "limited" set of Converters - but is the same problem as 1).

  3. When I have 2 WAR applications in Tomcat, and one application sets the System property "javax.xml.transform.TransformerFactory" for Xalan XSLTC, and the second application does not have Xalan on classpath and does not use the XSLT,but instantiates RestTemplate for JSON based communication, than Exception is thrown:

Caused by: javax.xml.transform.TransformerFactoryConfigurationError: Provider org.apache.xalan.xsltc.trax.TransformerFactoryImpl not found
	at javax.xml.transform.TransformerFactory.newInstance(TransformerFactory.java:107)
	at org.springframework.http.converter.xml.AbstractXmlHttpMessageConverter.<init>(AbstractXmlHttpMessageConverter.java:47)
	at org.springframework.http.converter.xml.SourceHttpMessageConverter.<init>(SourceHttpMessageConverter.java:47)
	at org.springframework.web.client.RestTemplate.<init>(RestTemplate.java:154)

I don´t want to initialize any default XML message Converter for RestTemplate, because I use only JSON for communication -> I want to configure my own set of MessageConverters, but the constructor is called first and destroyed by the exception.

So please, move the initialization of default MessageConvertors for RestTemplate from constructor to some @PostConstruct method, and initialize these default converters only in situations, when the Array of converters was not set (preinitialized) by setMessageConventers(...) operation from configuration.


Affects: 3.2.4, 4.0 GA

Issue Links:

  • #16578 Backward compatibility issue in RestTemplate's messageConverters after SPR-11351

Referenced from: commits 1cb9b9c, 425e5a0

Backported to: 3.2.7

0 votes, 8 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 23, 2014

Dave Syer commented

Just so you are aware, Spring Boot provides an HttpMessageConverters convenience @Bean which you can use to grab a global list of message converters to initialize your RestTemplate and MVC stuff. We could copy that in Spring and make the user install that bean himself, I guess. Or we could recommend the use of Spring Boot (probably better for everyone).

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 27, 2014

Rossen Stoyanchev commented

The RestTemplate can be instantiated directly, not necessarily through Spring configuration so @PostContruct callbacks won't apply there. We could introduce additional constructors accepting a list of converters. Arjen Poutsma, any other suggestions?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 27, 2014

Arjen Poutsma commented

Rossen Stoyanchev that constructor sounds like a good idea.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 28, 2014

Brian Clozel commented

Resolved on master with change 425e5a06.
Juergen Hoeller, this is ready for backport on the 3.2.x branch.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 28, 2014

Juergen Hoeller commented

Looks good, Brian! Backported to 3.2.x as well now.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 28, 2014

Kek commented

Thank you very much for the quick fix, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants