Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose HTTP status for handshake failures [SPR-11368] #15994

Closed
spring-projects-issues opened this issue Jan 29, 2014 · 1 comment
Closed

Choose HTTP status for handshake failures [SPR-11368] #15994

spring-projects-issues opened this issue Jan 29, 2014 · 1 comment
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 29, 2014

Brian Clozel opened SPR-11368 and commented

As stated in this wicket issue, regarding handshake errors.

RFC6455 states that the websocket server can send a HTTP 400 "Bad Request" or a HTTP 426 "Upgrade Required".

Problem is, some clients won't support HTTP 426 since it's not listed in RFC2616.

So we should decide to:

  • keep the current implementation and stick with HTTP 426
  • or use HTTP 400 for compatibility reasons (do we have real examples of client incompatibility with that HTTP status?)

Affects: 4.0.1

Reference URL: https://issues.apache.org/jira/browse/WICKET-5453

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 31, 2014

Brian Clozel commented

I did not find info suggesting that HTTP/websockets clients don't support this status. In fact, websocket clients should support it since it's explicitely described in RFC-6455.

Apache Tomcat is using HTTP 426 for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants