Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double evaluation of method arguments in SpEL [SPR-11445] #16071

Closed
spring-projects-issues opened this issue Feb 19, 2014 · 5 comments
Closed

double evaluation of method arguments in SpEL [SPR-11445] #16071

spring-projects-issues opened this issue Feb 19, 2014 · 5 comments
Assignees
Labels
in: core status: backported type: regression
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Feb 19, 2014

Björn Voß opened SPR-11445 and commented

Since version 3.2.5 in expressions like

"dummyAction.isSero(dummyBean.getCalls())"

the argument part "dummyBean.getCalls()" is evaluated twice

see attached a little project for testing.
if you change the propertie 'spring.version' to 3.2.4.RELEASE the test is green. On all later versions the test fails.


Affects: 3.2.5, 3.2.6, 3.2.7, 3.2.8, 4.0.1, 4.0.2

Attachments:

Referenced from: commits 519799e, b1bcc5d

Backported to: 3.2.9

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 6, 2014

Stéphane Nicoll commented

I have added a sample project that reproduces this issue without webflow:
https://github.com/spring-projects/spring-framework-issues/tree/master/SPR-11445

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 6, 2014

Stéphane Nicoll commented

Broken by 3157b68, the arguments are indeed resolved twice since that change. Fixing that.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 6, 2014

Stéphane Nicoll commented

This has been fixed on master and the backport to 3.2 is scheduled for our next round. Your sample project works fine against master now.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 7, 2014

Juergen Hoeller commented

This is available in the latest 4.0.3 snapshot already, and will be available in the immediately upcoming 3.2.9 snapshot as well (see http://projects.spring.io/spring-framework/ for Maven coordinates). Please give it a try and let us know whether it works for you...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 11, 2014

Björn Voß commented

Looks good for me
Thx!

@spring-projects-issues spring-projects-issues added type: regression status: backported in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: backported type: regression
Projects
None yet
Development

No branches or pull requests

2 participants