Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat empty log config refresh interval as infinite interval in Log4jWebConfigurer [SPR-11507] #16132

Closed
spring-projects-issues opened this issue Mar 4, 2014 · 0 comments
Assignees
Labels
in: web status: backported type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Mar 4, 2014

Dmitry Katsubo opened SPR-11507 and commented

Currently if log4jRefreshInterval is empty, Log4jWebConfigurer throws an exception because the value is not a number. Consider the following scenario when value is substituted by Maven (resource filtering = true):

<context-param>
	<param-name>log4jRefreshInterval</param-name>
	<param-value>${log4j.refresh.interval}</param-value>
</context-param>

If log4j.refresh.interval is empty, application does not start. The solution is either to set log4j.refresh.interval to big value like 9999999, or do some fuzzy things in Maven POM to juggle two different web.xml files.

Suggestion:

Log4jWebConfigurer should treat empty refresh interval as not-defined.


Affects: 3.2.8, 4.0.1

Attachments:

Backported to: 3.2.9

@spring-projects-issues spring-projects-issues added status: backported type: enhancement in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web status: backported type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants