Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay-port type in xsd should be string [SPR-11537] #16162

Closed
spring-projects-issues opened this issue Mar 11, 2014 · 2 comments
Closed

relay-port type in xsd should be string [SPR-11537] #16162

spring-projects-issues opened this issue Mar 11, 2014 · 2 comments
Assignees
Labels
in: web type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Mar 11, 2014

Mark Galea opened SPR-11537 and commented

The relay-port type in the spring-websocket-4.x.xsd should be xsd:string instead of xsd:int. This would allow us to use properties configured through a PropertyPlaceholderConfigurer to configure the stomp-broker-relay port under different production environments.


Affects: 4.0.1, 4.0.2

Issue Links:

  • #14187 Relax jms:listener-container xsd:int attributes to xsd:string in order to allow for SpEL expressions

Referenced from: commits 8b2b165

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 11, 2014

Juergen Hoeller commented

Rossen, we have redeclared a few int attributes to string in other xsds already, for the same reason... So this would fit nicely, even for 4.0.3.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 17, 2014

Mark Galea commented

Could we also relax the xsd:boolean websocket-enabled (on the websocket:sockjs element so that it can be controller via properties configured through a PropertyPlaceholderConfigurer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants