Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch source encoding to UTF-8 and enforce it in the build [SPR-11569] #16193

Closed
spring-projects-issues opened this issue Mar 17, 2014 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Mar 17, 2014

Stéphane Nicoll opened SPR-11569 and commented

We have been referring to ISO-8859-1 for the encoding of our source files but nothing in our build enforces it and most of the new code base is probably encoded with UTF-8.

Unless there's a valid reason to use latin instead of UTF-8 we should fix at least master and configure gradle to make sure that resources are compiled/copied with that encoding instead of relying on the default.


Issue Links:

  • #19115 HttpHeaders.setContentDispositionFormData() doesn't encode non-acsii characters correctly

5 votes, 6 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 15, 2016

Sam Brannen commented

Why don't we slate this for 5.0?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 25, 2016

Stéphane Nicoll commented

Source files were already UTF-8 encoded so it was about configuring the compiler. This is done now on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants