Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default use of SimpleAsyncTaskExecutor in WebSocketClient implementations [SPR-11580] #16204

Closed
spring-projects-issues opened this issue Mar 19, 2014 · 0 comments
Assignees
Labels
in: web type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Mar 19, 2014

Rossen Stoyanchev opened SPR-11580 and commented

Currently WebSocketClient implementations use a SimpleAsyncTaskExecutor by default to avoid blocking when connecting.

Not using any executor is arguably a better default for the case where a large number of connections are made. If connections are opened quickly, the difference probably won't be noticed, or if they're slow it leads to a realization that a task executor can be configured.

By contrast a SimpleAsyncTaskExecutor leads to thread creation, a more subtle effect that is harder to realize.


Affects: 4.0.2

Referenced from: commits 9552c82

@spring-projects-issues spring-projects-issues added type: enhancement in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants