Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide defensive mechanism to prevent slow WebSocket clients from consuming server resources [SPR-11586] #16210

Closed
spring-projects-issues opened this issue Mar 20, 2014 · 4 comments
Assignees
Labels
in: web type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Mar 20, 2014

Rossen Stoyanchev opened SPR-11586 and commented

When sending messages to slow WebSocket clients through a WebSocketSession, which could be an actual WebSocket or an HTTP based (fallback) transport, the thread(s) performing the send can be held up. As more messages are broadcast the problem compounds.

There needs to be a defensive mechanism to guard against this situation and prevent a slow client from consuming more than a single thread.

Some degree of buffering along with a timeout value are required to ensure that the slow client is eventually removed completely.


Affects: 4.0.2

This issue is a sub-task of #16076

1 votes, 5 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 22, 2016

Frik Strecker commented

How is this resolved? We are having this issue in production where a slow client is dragging the entire server down.

Thanks!

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 22, 2016

Frik Strecker commented

Now that it lists the commits, it looks like no action is needed on our part except to upgrade. (Previously it would not list the commits.)

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 22, 2016

Juergen Hoeller commented

Frik Strecker, since this issue is closed already, please create a new issue with your specific conditions... We'll just mark it as related to this issue then.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 22, 2016

Rossen Stoyanchev commented

I would suggest upgrading to the latest 4.2.x at least or 4.3.x. The 4.0.x line will not change any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: task
Projects
None yet
Development

No branches or pull requests

2 participants