Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipartFile interface should extend InputStreamSource [SPR-11861] #16480

Closed
spring-issuemaster opened this issue Jun 10, 2014 · 5 comments
Closed
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jun 10, 2014

Dmitry Katsubo opened SPR-11861 and commented

Seems logical that org.springframework.web.multipart.MultipartFile interface extends org.springframework.core.io.InputStreamSource, as it is a provider of a stream:

public interface MultipartFile extends InputStreamSource { ...

Affects: 4.0.3

Attachments:

Referenced from: commits f0c6bff

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 6, 2015

Dmitry Katsubo commented

Should I create a pull for this change? I think that proposed improvement is transparent for the whole framework.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 6, 2015

Juergen Hoeller commented

I'll address this for 4.2 GA still. No need for a pull request, it's a straightforward enough change anyway...

Juergen

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 6, 2015

Dmitry Katsubo commented

It would be great if you could push it to 4.1.8 as well. Thanks!

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 6, 2015

Juergen Hoeller commented

We usually don't backport this kind of change at such a late point of a branch.

Note that 4.2 (as a feature release) goes GA next week, whereas 4.1.8 (as a plain bug-fix release) won't be released before September anyway...

Juergen

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 7, 2015

Dmitry Katsubo commented

Thanks, that's fair. Let it be 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.