Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide the fate of HibernateEntityManagerFactoryIntegrationTests [SPR-11922] #16540

Closed
spring-projects-issues opened this issue Jun 26, 2014 · 2 comments
Assignees
Labels
in: data type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 26, 2014

Sam Brannen opened SPR-11922 and commented

Status Quo

HibernateEntityManagerFactoryIntegrationTests in the spring-orm module is currently disabled and has been for quite some time.

The reason these tests are disabled is that the AnnotationBeanConfigurerAspect cannot be found because it resides in the spring-aspects module which depends on the spring-orm module.

Proposal

In order to avoid a cyclical dependency between spring-aspects and spring-orm, HibernateEntityManagerFactoryIntegrationTests could be moved to the root spring' module as a framework-level integration test, but the challenge with doing so is that this class depends on classes which are defined in src/test/java for the spring-orm module.

Deliverables

Decide the fate of HibernateEntityManagerFactoryIntegrationTests:

  1. refactor it so that it works without @Configurable?
  2. delete it?
  3. move it to the root spring module?

Affects: 4.0 GA

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 1, 2014

Juergen Hoeller commented

Sam, I'd opt for simply removing the @Configurable stuff there. Let's do that right away for RC1.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 2, 2014

Sam Brannen commented

Completed as described in the comments for GitHub commit 32b8707:

Re-enable Hibernate EntityManagerFactory tests

HibernateEntityManagerFactoryIntegrationTests in the spring-orm module
has been disabled for quite some time due to a dependency on the
AnnotationBeanConfigurerAspect from the spring-aspects module. Since
spring-aspects depends on spring-orm, a cyclical dependency would
result if this code were re-enabled "as is".

This commit removes the dependency on AnnotationBeanConfigurerAspect in
HibernateEntityManagerFactoryIntegrationTests by deleting all test code
and configuration related to @Configurable. In addition, this commit
also deletes all SessionFactory-specific test code in
HibernateEntityManagerFactoryIntegrationTests, allowing the test class
to focus on Hibernate as a JPA provider.

@spring-projects-issues spring-projects-issues added in: data type: task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data type: task
Projects
None yet
Development

No branches or pull requests

2 participants