Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic for removing subscriptions from DefaultSubscriptionRegistry [SPR-11930] #16548

Closed
spring-projects-issues opened this issue Jun 30, 2014 · 2 comments
Assignees
Labels
in: messaging type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 30, 2014

Rossen Stoyanchev opened SPR-11930 and commented

When removing a session, rather than a destination pattern based search, we should search for occurrences of the session id in the destination cache. It is arguably a more fail-safe way to guarantee the session is completely removed from the cache and would probably be more efficient.

A similar improvement could be made for individual subscriptions. When removing a subscription, search for occurrences of the session id in the destination cache, and then check if the subscription id is present.

In other words complete ignore destinations and focus on removing session and subscription ids.


Affects: 4.0.5

Issue Links:

  • #16549 DefaultSubscriptionRegistry does not update destination cache when subscribed twice to same destination

Referenced from: commits 5092414, ce20abd

1 votes, 2 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 1, 2014

Sébastien Deleuze commented

Sure !

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 1, 2014

Sébastien Deleuze commented

Pull request #576 submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants