Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultSubscriptionRegistry does not update destination cache when subscribed twice to same destination [SPR-11931] #16549

Closed
spring-projects-issues opened this issue Jun 30, 2014 · 4 comments
Assignees
Labels
in: messaging in: web type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 30, 2014

le roy arnaud opened SPR-11931 and commented

If you subscribe to the same destination twice on the same connection/session, and then you unscribe one of them the both remains.

after some search the problem could be into the cache mechanism.
probably at this point :

DefaultSubscriptionRegistry::removeSubscriptionInternal
....
if (info.getSubscriptions(destination) == null)
...


Affects: 4.0.5

Issue Links:

  • #16548 Improve logic for removing subscriptions from DefaultSubscriptionRegistry

Referenced from: commits 083d415, 5092414

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 1, 2014

Sébastien Deleuze commented

Pull request #576 submitted.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 1, 2014

Rossen Stoyanchev commented

le roy arnaud would be great to try out the fixes with 4.0.6.BUILD-SNAPSHOT once a good build is available here.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 2, 2014

le roy arnaud commented

It works, i can't reproduce the problem after the patch.

thx

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 2, 2014

Rossen Stoyanchev commented

Thanks for confirming!

@spring-projects-issues spring-projects-issues added type: bug in: messaging in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.6 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging in: web type: bug
Projects
None yet
Development

No branches or pull requests

2 participants