Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build to Gradle 2.2.1 [SPR-11934] #16551

Closed
spring-issuemaster opened this issue Jul 1, 2014 · 16 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jul 1, 2014

Sam Brannen opened SPR-11934 and commented

Deliverables

  1. MergePlugin is incompatible with Gradle 2.0.
    • Fixed in master; see comments section.
  2. propdeps-plugin version 0.0.6 (the version currently used in build.gradle) is incompatible with Gradle 2.0.
  3. spring-aspects fails to compile against Gradle 2.0.
    • See Aspect Compilation Errors below.

Aspect Compilation Errors

The spring-aspects module fails to compile against Gradle 2.0. See below for details.

:spring-aspects:compileJava
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJCachingConfiguration.java:40: error: cannot find symbol
	public AnnotationCacheAspect cacheAspect() {
	       ^
  symbol:   class AnnotationCacheAspect
  location: class AspectJCachingConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJJCacheConfiguration.java:42: error: cannot find symbol
	public JCacheCacheAspect cacheAspect() {
	       ^
  symbol:   class JCacheCacheAspect
  location: class AspectJJCacheConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/context/annotation/aspectj/SpringConfiguredConfiguration.java:19: error: cannot find symbol
import org.springframework.beans.factory.aspectj.AnnotationBeanConfigurerAspect;
                                                ^
  symbol:   class AnnotationBeanConfigurerAspect
  location: package org.springframework.beans.factory.aspectj
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/context/annotation/aspectj/SpringConfiguredConfiguration.java:47: error: cannot find symbol
	public AnnotationBeanConfigurerAspect beanConfigurerAspect() {
	       ^
  symbol:   class AnnotationBeanConfigurerAspect
  location: class SpringConfiguredConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/scheduling/aspectj/AspectJAsyncConfiguration.java:42: error: cannot find symbol
	public AnnotationAsyncExecutionAspect asyncAdvisor() {
	       ^
  symbol:   class AnnotationAsyncExecutionAspect
  location: class AspectJAsyncConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/transaction/aspectj/AspectJTransactionManagementConfiguration.java:42: error: cannot find symbol
	public AnnotationTransactionAspect transactionAspect() {
	       ^
  symbol:   class AnnotationTransactionAspect
  location: class AspectJTransactionManagementConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJCachingConfiguration.java:36: warning: [rawtypes] found raw type: AbstractCachingConfiguration
public class AspectJCachingConfiguration extends AbstractCachingConfiguration {
                                                 ^
  missing type arguments for generic class AbstractCachingConfiguration<C>
  where C is a type-variable:
    C extends CachingConfigurer declared in class AbstractCachingConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJCachingConfiguration.java:41: error: cannot find symbol
		AnnotationCacheAspect cacheAspect = AnnotationCacheAspect.aspectOf();
		^
  symbol:   class AnnotationCacheAspect
  location: class AspectJCachingConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJCachingConfiguration.java:41: error: cannot find symbol
		AnnotationCacheAspect cacheAspect = AnnotationCacheAspect.aspectOf();
		                                    ^
  symbol:   variable AnnotationCacheAspect
  location: class AspectJCachingConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJJCacheConfiguration.java:43: error: cannot find symbol
		JCacheCacheAspect cacheAspect = JCacheCacheAspect.aspectOf();
		^
  symbol:   class JCacheCacheAspect
  location: class AspectJJCacheConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/cache/aspectj/AspectJJCacheConfiguration.java:43: error: cannot find symbol
		JCacheCacheAspect cacheAspect = JCacheCacheAspect.aspectOf();
		                                ^
  symbol:   variable JCacheCacheAspect
  location: class AspectJJCacheConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/context/annotation/aspectj/SpringConfiguredConfiguration.java:48: error: cannot find symbol
		return AnnotationBeanConfigurerAspect.aspectOf();
		       ^
  symbol:   variable AnnotationBeanConfigurerAspect
  location: class SpringConfiguredConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/scheduling/aspectj/AspectJAsyncConfiguration.java:43: error: cannot find symbol
		AnnotationAsyncExecutionAspect asyncAspect = AnnotationAsyncExecutionAspect.aspectOf();
		^
  symbol:   class AnnotationAsyncExecutionAspect
  location: class AspectJAsyncConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/scheduling/aspectj/AspectJAsyncConfiguration.java:43: error: cannot find symbol
		AnnotationAsyncExecutionAspect asyncAspect = AnnotationAsyncExecutionAspect.aspectOf();
		                                             ^
  symbol:   variable AnnotationAsyncExecutionAspect
  location: class AspectJAsyncConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/transaction/aspectj/AspectJTransactionManagementConfiguration.java:43: error: cannot find symbol
		AnnotationTransactionAspect txAspect = AnnotationTransactionAspect.aspectOf();
		^
  symbol:   class AnnotationTransactionAspect
  location: class AspectJTransactionManagementConfiguration
/Users/sbrannen/source/spring-framework/spring-aspects/src/main/java/org/springframework/transaction/aspectj/AspectJTransactionManagementConfiguration.java:43: error: cannot find symbol
		AnnotationTransactionAspect txAspect = AnnotationTransactionAspect.aspectOf();
		                                       ^
  symbol:   variable AnnotationTransactionAspect
  location: class AspectJTransactionManagementConfiguration
15 errors
1 warning
:spring-aspects:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':spring-aspects:compileJava'.
> Compilation failed; see the compiler error output for details.

Attachments:

Issue Links:

  • #17369 Upgrade build to Gradle 2.4 ("is depended on by")

Referenced from: commits 7497391, 3662ad4, 48236be, f40d67c

1 votes, 9 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

Our custom Gradle MergePlugin now uses syntax appropriate for Gradle 2.0. See GitHub commit 7497391 for details.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

Attached Gradle build patch to use 0.0.7-SNAPSHOT of the propdeps-plugin (required for Gradle 2.0) until 0.0.7 is officially released.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

Phil Webb and Rob Winch, can one of you please take a look at the issue we are having with AspectJ and Gradle 2.0?

Thanks,

Sam

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Stéphane Nicoll commented

Hey. I am confused as why we would need to do this now (i.e. in a almost RC phase and without any confirmation that the IDE is going to support it). What is the requirement? (except using the latest of course)

Thanks!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

As far as I know, there is no immediate requirement to upgrade other than to stay current on performance enhancements, etc.

Regarding "the IDE", I assume you are referring to IntelliJ, and I cannot assess what an upgrade to Gradle 2.0 might entail for IntelliJ.

For Eclipse we generate all of the project metadata from the command line. So in that regard, the IDE is not a concern per se.

If the team deems it ill advised to upgrade Gradle at this time, we can postpone this issue.

Regards,

Sam

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Stéphane Nicoll commented

Yeah, I am sorry. I meant IDEA. I would do that after 4.1 but it would require a round of tests with the IDE we use anyway. Thanks!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Rob Winch commented

propdeps 0.0.7 has been released

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

Upgraded propdeps-plugin to version 0.0.7 for Gradle 2.0 support. See GitHub commit f40d67c for details.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

Thanks, Rob Winch!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2014

Sam Brannen commented

I would do that after 4.1 but it would require a round of tests with the IDE we use anyway.

I've assigned the issue to Phil. So I'll leave the fix version up to him now. ;)

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 18, 2014

Juergen Hoeller commented

The compilation classpath problem in the spring-aspects module isn't resolved yet, so let's rather revisit this for RC2.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 27, 2014

Stéphane Nicoll commented

The upgrade to the latest Sonar version broke our build so we really have to upgrade now.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 27, 2014

Juergen Hoeller commented

I'd rather downgrade Sonar than rush the Gradle build upgrade here. This is a perfect fit for the 4.2 line that we're about to start anyway, so unless there's a critical reason, I'm not in favor of squeezing it into 4.1.3...

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 5, 2015

Stéphane Nicoll commented

The build on master has been upgraded to Gradle 2.2.1 - We have also restored the sonar analysis on sonar.spring.io

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 1, 2015

Juergen Hoeller commented

I guess we should upgrade to Gradle 2.3 now, once a 2.3.1 is available or so...

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 1, 2015

Sam Brannen commented

Sure. I created #17369 to track Gradle 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.