Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedValue should have proper equals(…) / hashCode() methods [SPR-11960] #16576

Closed
spring-projects-issues opened this issue Jul 5, 2014 · 1 comment
Closed

TypedValue should have proper equals(…) / hashCode() methods [SPR-11960] #16576

spring-projects-issues opened this issue Jul 5, 2014 · 1 comment
Assignees
@jhoeller
Labels
in: core type: enhancement
Milestone
4.0.6

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 5, 2014

Oliver Drotbohm opened SPR-11960 and commented

When implementing unit tests against custom PropertyAccessor and MathodResolver instances it would be helpful if TypedValue would adhere to value object semantics and be equal if the set value and type is equal.

assertThat(new TypedValue("value"), is(new TypedValued("value")));

Affects: 3.2.9, 4.0.5

Referenced from: commits 6dbb465, a8848cb
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 7, 2014

Juergen Hoeller commented

Good point. Fixed for 4.1 and backported to 4.0.6 now.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.6 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core type: enhancement
Projects
None yet
Milestone
4.0.6
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues