Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ResourceHandlerRegistration API for resource transformers/resolvers [SPR-11982] #16598

Closed
spring-issuemaster opened this issue Jul 10, 2014 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jul 10, 2014

Brian Clozel opened SPR-11982 and commented

Provide methods on ResourceHandlerRegistration in order to help configuring ResourceTransformers and ResourceResolvers in common use cases:

  • javascript webapps in production mode
  • javascript webapps in dev mode

Issue Links:

  • #16745 Update MVC namespace to match improvements made to the Java config in RC2

Referenced from: commits 95e9b38

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 25, 2014

Guillaume DROUET commented

Hi,

when I configure the registry, I don't see why we must always call addResourceLocations(). By default this method is helpful to find resources but we should be able to fully delegate this task to the ResourceHandler. So I think we should relax this rule by checking if at least one ResourceResolver has been added before throwing an IAE.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.