allow value expressions for messaging listener annotation destinations [SPR-12134]

[spring-projects-issues]

zyro opened SPR-12134 and commented

using jms messaging as example here. but probably other messaging impls (websocket, amqp, etc.) show the same behavior.

currently, only "plain" String destinations are supported for the destination argument of @JmsListener. we faced a use case where it made sense to pull those values out of properties. i think this can be generalized to a request for support of injection/resolution of value expressions for destination arguments (e.g. just like it works with @Value).

the following example code shows our current workaround, which could likely be implemented in a better way but it shows the desired behavior:

@Configuration
@EnableJms
public class JmsConfiguration {

	@Autowired
	private CustomDynamicDestinationResolver destinationResolver;
	
	@Bean
	public DefaultJmsListenerContainerFactory jmsListenerContainerFactory(final ConnectionFactory connectionFactory) {
		final DefaultJmsListenerContainerFactory factory = new DefaultJmsListenerContainerFactory();
		factory.setConnectionFactory(connectionFactory);
		factory.setDestinationResolver(destinationResolver);
		return factory;
	}

}

@Component
public class ExampleReceiver {

	@JmsListener(containerFactory = "jmsListenerContainerFactory", destination = "${my.destination.value.expression.property.key}")
	public void handleMessage(String example) {
		System.out.println(example);
	}

}

@Component
public class CustomDynamicDestinationResolver extends DynamicDestinationResolver {

	@Autowired
	private AbstractBeanFactory beanFactory;
	
	@Override
	public Destination resolveDestinationName(Session session, String destinationName, boolean pubSubDomain) throws JMSException {
		String parsedDestinationName = beanFactory.resolveEmbeddedValue(destinationName);
		return super.resolveDestinationName(session, parsedDestinationName, pubSubDomain);
	}
	
}

thanks, zyro

---

Affects: 4.1 RC2

Issue Links:

• AMQP-424 Allow value expressions for messaging listener annotation destinations

Referenced from: commits 8c4388d

[spring-projects-issues]

Stéphane Nicoll commented

Thanks for report. Just a thought, the jmsListenerContainerFactory value in your @JmsListener is unecessary as it matches the name of the default value. Check the doc for more details.

[spring-projects-issues]

Stéphane Nicoll commented

This one is easy enough to make it before 4.1.GA. All attributes can now be resolved using property place holders. I'll apply the same logic for @RabbitListener wherever it makes sense.

[spring-projects-issues]

zyro commented

awesome! thank you.